----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130058/ -----------------------------------------------------------
(Updated May 27, 2017, 4:32 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Stefan Brüns. Changes ------- Submitted with commit c2fe10e2e75304114de89aa83381cfa20e6e9734 by Andreas Sturmlechner on behalf of Stefan Brüns to branch master. Repository: kwallet Description ------- These are not my own patches, I'm creating this review request after having been made aware of *kwalletd4_dbus_compat* branch in kwallet.git, which I simply rebased on top of current master (author of course preserved) to be able to test it. I think it would be a great improvement over the current situation that is rather confusing to the users. The changes are organised in 5 commits: - Check for unique applicaton instance as early as possible Exit before KWalletD and the MigrationAgent has been initialized. The return value is changed, but concurrent instatiation of kwalletd is not a fault. - Only start timer for migration agent if necessary - Whitespace fixup - Signal completion of migration agent - Replace kwalletd4 after migration has finished kwalletd5 can service both org.kde.kwalletd5 and org.kde.kwalletd Diffs ----- src/runtime/kwalletd/kwalletd.h 3571535cd8bd78415002795f9b61adf9f6cfb8c1 src/runtime/kwalletd/kwalletd.cpp 18ef9fa7e6ddaeba6e0b32deae3de1dae39df5bb src/runtime/kwalletd/main.cpp ff9620886fa1959e14b594be6bbb4644b637c000 src/runtime/kwalletd/migrationagent.h 0f6467c1753ef34b7f7f7e282503ec5607927db9 src/runtime/kwalletd/migrationagent.cpp f3da94743ecd83fe406e058f560d4238caec1be8 Diff: https://git.reviewboard.kde.org/r/130058/diff/ Testing ------- Migration itself was not tested so far, but a legacy application like ksirk was able to create a new wallet just fine and can access it as well. I do not have kwalletd4 installed anymore. Thanks, Andreas Sturmlechner
