davidedmundson added a comment.

  Relavent follow up to the unanswer question from yesterday:
  
  why does the implicit height change when we show it
  
  It's from some code in NotificationItem.qml
  
    ColumnLayout {
        id: mainLayout
        anchors {
             left: appIconItem.visible || imageItem.visible ? appIconItem.right 
: parent.left
  
  This changes when we show the popup, the width available show the text, that 
changes the implicitHeight of the dialog, which changes the actual height.
  
  I /think/ changing them to check whether the image is loaded rather than 
visible will fix that issue.
  I commented it out and gammaray no longer shows the implicitHeight changing

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

Reply via email to