ltoscano added a comment.

  It seems to work, just one question though:

INLINE COMMENTS

> KF5I18NMacros.cmake:178
> +      set(pmapc_target "pmapfiles-${lang}")
> +      add_custom_target(${pmapc_target} ALL DEPENDS ${pmapc_files})
> +      add_dependencies(pmapfiles ${pmapc_target})

Before this line, in the original version before the changes, there was this 
line:

  string(REPLACE "@" "_" pmapc_target ${pmapc_target})

Could it be still relevant?

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D6331

To: apol, #frameworks, ltoscano, lueck, aacid
Cc: aacid, asturmlechner

Reply via email to