> On July 12, 2017, 9:11 a.m., Kevin Funk wrote: > > src/kdecore/kurl.h, line 437 > > <https://git.reviewboard.kde.org/r/130177/diff/1/?file=497118#file497118line437> > > > > Maybe it's also worth pointing people to > > `QUrl::toDisplayString(QUrl::PreferLocalFile | ...)` as well -- because in > > fact that's what most people want when having used `KUrl::path()` before. > > > > I've fixed `QUrl::toDisplayString(QUrl::PreferLocalFile | ...)` in Qt > > 5.6 to do what one would expect from it... > > David Faure wrote: > I wouldn't point to QUrl::toDisplayString(), because that's definitely > not what KUrl::path() was doing before (think about remote URLs). > > The correct migration path from KUrl::path() is indeed QUrl::path() or > QUrl::toLocalFile() (because a lot of the old code written with KUrl is from > before toLocalFile() even existed, back from when we didn't really support > Windows).
Fair enough. I've probably just seen too many wrong ports of `KUrl::path()` to `QUrl::path()` where people actually wanted `QUrl::toDisplayString(...)`... - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130177/#review103432 ----------------------------------------------------------- On July 12, 2017, 6:10 a.m., Ralf Habacker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130177/ > ----------------------------------------------------------- > > (Updated July 12, 2017, 6:10 a.m.) > > > Review request for KDE Frameworks. > > > Bugs: 382242 > https://bugs.kde.org/show_bug.cgi?id=382242 > > > Repository: kdelibs4support > > > Description > ------- > > This patch extends the documentation of KUrl::path() to use toLocalFile() for > local file urls. See bug for more details > > > Diffs > ----- > > src/kdecore/kurl.h 1dcd77cca66b4ebc6fcdaa36a5451a71227eecb7 > > Diff: https://git.reviewboard.kde.org/r/130177/diff/ > > > Testing > ------- > > > Thanks, > > Ralf Habacker > >