----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130180/#review103453 -----------------------------------------------------------
Ship it! Inviala! - Simone Gaiarin On Lug. 12, 2017, 6:54 p.m., Simone Gaiarin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130180/ > ----------------------------------------------------------- > > (Updated Lug. 12, 2017, 6:54 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 359233 > https://bugs.kde.org/show_bug.cgi?id=359233 > > > Repository: kio > > > Description > ------- > > The current "open with" dialog implementation does not follow the KDE > principle "Simple by default, powerful when needed" for the following reasons: > - The "run in terminal" and "keep terminal open" options are advanced options > and should not be exposed by default > - The primary goal of the dialog should be to select an application from the > app tree, running command is an advanced feature > > My patch changes the behavior as follow: > > - Put the two options in a KCollapsibleComboBox collapsed by default > - The user can expand it only if he needs to use a command line command > > > Implementation details: > - When the KCollapsibleComboBox is clicked it is expanded upward keeping the > dialog size fixed and compressing the treeview, I'm not sure this is the best > approach, but to make it expand downwards we need to fix the size of the > dialog with setSizeConstraint(QLayout::SetFixedSize); which may not be > desiderable. Maybe there is a way to keep the dialog resizable and expand the > combobox downwards, but I couldn't find it. > - I've increased the vertical size of the dialog (which I think it was too > small) also to accomodate the upward expansion which otherwise would make the > app tree almost disappear > > > Relevant discussions: > https://bugs.kde.org/show_bug.cgi?id=359233 > https://forum.kde.org/viewtopic.php?f=285&t=131014 > > > Diffs > ----- > > src/widgets/kopenwithdialog.cpp b28c5b05186bc77413524c99ef61b7967b0ec8b9 > > Diff: https://git.reviewboard.kde.org/r/130180/diff/ > > > Testing > ------- > > > Thanks, > > Simone Gaiarin > >