sitter marked 2 inline comments as done.
sitter added a comment.
Oh, actually. Maybe we could/should make `KAboutLicense::KAboutLicense(const
KAboutData *aboutData)` delegate to the "full" public ctor. Then we can drop
`Private(const KAboutData *aboutData);` entirely.
Like so
KAboutLicense::KAboutLicense(LicenseKey licenseType,
VersionRestriction versionRestriction,
const KAboutData *aboutData)
: d(new Private(licenseType, versionRestriction, aboutData))
{
}
KAboutLicense::KAboutLicense(const KAboutData *aboutData)
: KAboutLicense(Unknown, OnlyThisVersion, aboutData)
{
}
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D6672
To: sitter, sebas, mpyne
Cc: #frameworks
