chinmoyr added inline comments.

INLINE COMMENTS

> dfaure wrote in copyjob.cpp:1674
> Should the flag always be set here? Or only if m_privilegeExecutionEnabled is 
> true?

Ideally it should be set when m_privilegeExecutionEnabled is true. But it will 
add more lines. Even though its just 2-3 lines, it doesn't look good. 
Besides the flag is ineffective if the parent job doesn't have this flag set. 
Shall I remove it?

REVISION DETAIL
  https://phabricator.kde.org/D6833

To: chinmoyr, dfaure, #frameworks
Cc: #frameworks

Reply via email to