dfaure added a comment.
Code looks good to me. INLINE COMMENTS > readonlypart.cpp:244 > > +// TODO KF6: make it non-virtual so that we can just call > +// closeUrlImpl() + setUrl(QUrl()) and get rid of m_closeUrlFromOpenUrl. I'm not sure about that TODO, it would be a horrendous porting trap (closeUrl not called anymore, no way to detect it unless `override` was used) I was commenting on the problem with this design, but I don't think we should actually change it, the bool works. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6856 To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop Cc: cullmann, #frameworks
