dfaure added inline comments. INLINE COMMENTS
> slavebase.cpp:1464 > + QByteArray buffer; > + buffer.setNum(0); > + send(MSG_PRIVILEGE_EXEC); Better in one line: const QByteArray buffer = "0"; > file.h:115 > + }; > + virtual bool execWithElevatedPrivilege(int error, ActionType action, > const QVariant &arg1, > + const QVariant &arg2 = QVariant(), Why virtual? Nothing inherits from this class, right? REVISION DETAIL https://phabricator.kde.org/D6829 To: chinmoyr, dfaure, #frameworks Cc: #frameworks
