Present: me, chinmoy, shortstheory
Minutes in the attachment.
Cheers,
Elvis
[Saturday, 12 August 2017] [12:01:15 CEST] <eang> Meeting!
[Saturday, 12 August 2017] [12:01:28 CEST] <IrcsomeBot> <shortstheory> Hey
[Saturday, 12 August 2017] [12:02:14 CEST] <eang> chinmoy: ?
[Saturday, 12 August 2017] [12:11:22 CEST] <chinmoy[m]> eang: i am here
[Saturday, 12 August 2017] [12:11:43 CEST] <eang> we can start then
[Saturday, 12 August 2017] [12:13:06 CEST] <chinmoy[m]> This week I finished my
work on KIO side
[Saturday, 12 August 2017] [12:13:49 CEST] <chinmoy[m]> Well the unit test are
not complete yet
[Saturday, 12 August 2017] [12:14:22 CEST] <chinmoy[m]> apart from that undo,
DnD, and rest of the file operatioons are working fine
[Saturday, 12 August 2017] [12:15:48 CEST] <chinmoy[m]> Today I will put all
the KIO related patches up for review
[Saturday, 12 August 2017] [12:16:22 CEST] <chinmoy[m]> I think we can talk
about dolphin's side now
[Saturday, 12 August 2017] [12:17:55 CEST] <eang> cool!
[Saturday, 12 August 2017] [12:19:36 CEST] <eang> you mentioned a new setting
in D7270, what's that for?
[Saturday, 12 August 2017] [12:19:37 CEST] <sKreamer> Diff 7270
"[FileUndoManager] Enable undoing changes in read-only folders" [Needs Review]
https://phabricator.kde.org/D7270
[Saturday, 12 August 2017] [12:20:32 CEST] <chinmoy[m]> I was thinking of a
toggle button in dolphin's setting for enabling or disabling undo
[Saturday, 12 August 2017] [12:21:21 CEST] <eang> why would I want to disable
undo?
[Saturday, 12 August 2017] [12:22:47 CEST] <chinmoy[m]> its disabling undo in
read-only directory :)
[Saturday, 12 August 2017] [12:23:06 CEST] <chinmoy[m]> some user might want
the changes to be permanent
[Saturday, 12 August 2017] [12:25:16 CEST] <IrcsomeBot> <shortstheory> Don't
think disabling makes much sense
[Saturday, 12 August 2017] [12:27:27 CEST] <chinmoy[m]> so it should be always
enabled then ?
[Saturday, 12 August 2017] [12:28:26 CEST] <eang> I haven't tested it yet, what
happens when I undo in a RO folder? Do I get the usual permission warning
dialog?
[Saturday, 12 August 2017] [12:28:37 CEST] <chinmoy[m]> yes
[Saturday, 12 August 2017] [12:33:55 CEST] <eang> the problem with settings is
that they clutter the UI, there should be a really good reason for adding a new
one
[Saturday, 12 August 2017] [12:34:20 CEST] <chinmoy[m]> ok i will remove it then
[Saturday, 12 August 2017] [12:34:24 CEST] <eang> also, it would be hard to
explain that it only affects the polkit case
[Saturday, 12 August 2017] [12:35:04 CEST] <IrcsomeBot> <shortstheory> Yeah
that too
[Saturday, 12 August 2017] [12:35:07 CEST] <eang> since we get the warning
dialog, that's enough imho
[Saturday, 12 August 2017] [12:35:25 CEST] <eang> if I don't want to undo, I
can just abort the job
[Saturday, 12 August 2017] [12:35:36 CEST] <chinmoy[m]> actually i was planing
something similar for drag and drop
[Saturday, 12 August 2017] [12:01:36 CEST] <IrcsomeBot> <shortstheory> It's
important to have this project 100% for release. Dfaure was telling me that a
lot of gsoc projects don't get shipped because they're only 80% there most of
the time
[Saturday, 12 August 2017] [12:01:36 CEST] <IrcsomeBot> <shortstheory> Though
he did say he was quite optimistic about this one
[Saturday, 12 August 2017] [12:01:37 CEST] <chinmoy[m]> in drop job theere is a
check for write permission. Depending on which drop menu is created. Shall I
remove that check?
[Saturday, 12 August 2017] [12:41:00 CEST] <eang> you mean the if
(!KProtocolManager::supportsWriting(m_destUrl)) check?
[Saturday, 12 August 2017] [12:41:20 CEST] <chinmoy[m]> no below that
[Saturday, 12 August 2017] [12:41:44 CEST] <eang> right. I think so
[Saturday, 12 August 2017] [12:42:13 CEST] <chinmoy[m]> on second thought
adding check for PrivilegeExecution flag should do the job.
[Saturday, 12 August 2017] [12:42:18 CEST] <eang> even though... this possibly
breaks non-dolphin clients?
[Saturday, 12 August 2017] [12:42:56 CEST] <chinmoy[m]> I was thinking of this
[Saturday, 12 August 2017] [12:42:57 CEST] <chinmoy[m]> if
(!m_destItem.isNull() && !m_destItem.isWritable() && !(m_flags &
KIO::PrivilegeExecution)) {
[Saturday, 12 August 2017] [12:42:58 CEST] <chinmoy[m]> return
KIO::ERR_WRITE_ACCESS_DENIED;
[Saturday, 12 August 2017] [12:42:59 CEST] <chinmoy[m]> }
[Saturday, 12 August 2017] [12:43:36 CEST] <eang> yep, this looks better
[Saturday, 12 August 2017] [12:44:45 CEST] <IrcsomeBot> <shortstheory> Yea
[Saturday, 12 August 2017] [12:46:28 CEST] <eang> all right, so drops
operations are still WIP?
[Saturday, 12 August 2017] [12:48:08 CEST] <chinmoy[m]> Its finished
[Saturday, 12 August 2017] [12:48:28 CEST] <chinmoy[m]> I have just pushed all
the changes to master
[Saturday, 12 August 2017] [12:48:36 CEST] <chinmoy[m]> check it out
[Saturday, 12 August 2017] [12:48:39 CEST] <eang> ok great
[Saturday, 12 August 2017] [12:48:58 CEST] <eang> so, what's missing from the
dolphin side?
[Saturday, 12 August 2017] [12:50:50 CEST] <chinmoy[m]> a setting to toggle
privilege execution, mass renaming as root, notification for user that they are
in read-only dir and privilege execution is available
[Saturday, 12 August 2017] [12:52:31 CEST] <eang> again, not sure we really
need a setting for that
[Saturday, 12 August 2017] [12:53:11 CEST] <eang> +1 for notifying though
[Saturday, 12 August 2017] [12:56:35 CEST] <chinmoy[m]> use this dolphin patch
https://paste.kde.org/pw4aotqra
[Saturday, 12 August 2017] [12:57:42 CEST] <eang> sorry, lunch is ready, bbl
[Saturday, 12 August 2017] [12:58:15 CEST] <chinmoy[m]> np
[Saturday, 12 August 2017] [14:09:57 CEST] <eang> chinmoy: back
[Saturday, 12 August 2017] [14:10:17 CEST] <eang> I actually wanted to move the
meetings at 9am UTC, but forgot to tell you
[Saturday, 12 August 2017] [14:20:17 CEST] <eang> chinmoy: have you tried to
ask dfaure about the mass renaming?
[Saturday, 12 August 2017] [14:48:11 CEST] <chinmoy[m]> eang: so next week 9am
then.
[Saturday, 12 August 2017] [14:48:28 CEST] <eang> ok thanks
[Saturday, 12 August 2017] [14:48:55 CEST] <chinmoy[m]> and I haven't asked
dfaure about mass rename yet
[Saturday, 12 August 2017] [14:49:58 CEST] <chinmoy[m]> btw I was thinking
about the notification thing i mentioned and coudn't come up with something
feasible
[Saturday, 12 August 2017] [14:50:05 CEST] Topic eang sets the channel topic to
"KDE development channel for everything about files management (Dolphin, KIO
and friends) | Join via Matrix: /join #freenode_#kde-fm:matrix.org | GSoC
Meeting every Saturday at 9 am UTC".
[Saturday, 12 August 2017] [14:50:53 CEST] <chinmoy[m]> the idea of overlaying
a lock on existing menu icons requires too much work
[Saturday, 12 August 2017] [14:50:58 CEST] <chinmoy[m]> have you any ideas?
[Saturday, 12 August 2017] [14:53:09 CEST] <eang> hmm, we already overlay a
lock on unreadable dolphinview items
[Saturday, 12 August 2017] [14:53:46 CEST] <chinmoy[m]> I was talking about
overlaying it in context menu icons
[Saturday, 12 August 2017] [14:53:52 CEST] <eang> so a lock with another
meaning could be a problem
[Saturday, 12 August 2017] [14:53:55 CEST] <eang> yeah
[Saturday, 12 August 2017] [14:54:07 CEST] <eang> alternatives:
[Saturday, 12 August 2017] [14:54:36 CEST] <eang> some symbol in the window
title if we are in a RO folder?
[Saturday, 12 August 2017] [14:55:26 CEST] <chinmoy[m]> that will require way
too much discussion
[Saturday, 12 August 2017] [14:55:42 CEST] <eang> though that doesn't
necessarily means the children will be read-protected
[Saturday, 12 August 2017] [14:58:34 CEST] <eang> another idea could be playing
with colors, but that's also not easy
[Saturday, 12 August 2017] [15:00:10 CEST] <eang> I think we can also live
without notifications
[Saturday, 12 August 2017] [15:01:09 CEST] <eang> kwrite/kate don't do anything
particular when opening root files
[Saturday, 12 August 2017] [15:03:12 CEST] <chinmoy[m]> I surely can do without
notfications. It would definitely make my work easier if others could do
without it as well.
[Saturday, 12 August 2017] [15:04:00 CEST] <eang> what we really need are good
text messages in the auth/warning dialogs
[Saturday, 12 August 2017] [15:04:57 CEST] <chinmoy[m]> true that.
[Saturday, 12 August 2017] [15:05:29 CEST] <eang> anything else?
[Saturday, 12 August 2017] [15:06:01 CEST] <eang> I'll test the new patches asap
[Saturday, 12 August 2017] [15:06:20 CEST] <chinmoy[m]> If we decide not to
have any sort of toggle button then what to do with the code for writability
check
[Saturday, 12 August 2017] [15:07:50 CEST] <chinmoy[m]> there's too much code
and removing it would break things in most part of dolphin
[Saturday, 12 August 2017] [15:09:18 CEST] <eang> hmm so you wanted to add this
toggle so that you could just add the KIO::PrivilegeExecution if the user
opts-in?
[Saturday, 12 August 2017] [15:09:40 CEST] <chinmoy[m]> yup
[Saturday, 12 August 2017] [15:15:12 CEST] <eang> but then I'm not sure how
this would help avoiding any breakage
[Saturday, 12 August 2017] [15:20:15 CEST] <eang> chinmoy: what about the
actions? would you always enable them, or only if the setting is checked?
[Saturday, 12 August 2017] [15:53:32 CEST] <chinmoy[m]> eang, only if the
setting is checked
[Saturday, 12 August 2017] [15:57:36 CEST] <eang> chinmoy: I don't understand
how that would help
[Saturday, 12 August 2017] [15:58:03 CEST] <eang> we would break things when we
enable the setting, no?
[Saturday, 12 August 2017] [15:58:13 CEST] <eang> unless I'm missing something
[Saturday, 12 August 2017] [16:00:36 CEST] <eang> in general I'd vote for "no
setting, don't be afraid to break things"
[Saturday, 12 August 2017] [16:00:42 CEST] <eang> there is always time to fix
regressions
[Saturday, 12 August 2017] [16:01:29 CEST] <chinmoy[m]> ok so we will simple
and straightforward
[Saturday, 12 August 2017] [16:01:37 CEST] <chinmoy[m]> nothing fancy
[Saturday, 12 August 2017] [16:02:28 CEST] <chinmoy[m]> after i complete my
unit tests and get feedback from Thiago I will start working on dolphin
[Saturday, 12 August 2017] [16:03:11 CEST] <eang> all right, that's all?
[Saturday, 12 August 2017] [16:03:18 CEST] <chinmoy[m]> yes
[Saturday, 12 August 2017] [16:03:19 CEST] <eang> if yes, meeting over!
