martonmiklos marked an inline comment as done.
martonmiklos added a comment.


  In https://phabricator.kde.org/D7367#138030, @cullmann wrote:
  
  > I am happy beside one thing I missed: I think the file should be called 
intelhex.xml, given its for the intel hex format only (the name is already 
fine, did miss that the filename is only hex).
  >  Otherwise: very nice, thanks again for the contribution.
  
  
  I agree with the renaming, uploaded a new diff with the proper filename. I am 
not really familiar with the Phabricator (yet), do I need to do anything else?

REVISION DETAIL
  https://phabricator.kde.org/D7367

To: martonmiklos, #framework_syntax_hightlighting, cullmann
Cc: dhaumann, cullmann, #frameworks, vkrause

Reply via email to