bshah marked an inline comment as done.
bshah added inline comments.

INLINE COMMENTS

> dfaure wrote in slave.cpp:111
> } else if (...) {
> 
> We don't want/need to turn reply into a bool if it's not valid.
> 
> Alternatively this could be written as
> 
>   if (!reply.isValid() || getuid() != reply) // not running, or owned by a 
> different user
> 
> but I don't mind either way.

somehow arc diff is failing on me to update this change's summary and 
description.. I will commit this change and summary change .

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7462

To: bshah, #frameworks, sitter, dfaure

Reply via email to