kfunk added a comment.
Just wanted to add this: Really great work! -- I wanted to raise this issue earlier on the KF5 mailing list: ki18n was the last major framework that depended on the deprecated QtScript. Nice to see it being ported! <3 Can't really review this code either, though. I don't now enough about the QtScript/QtQML differences. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D7033 To: carewolf, ilic Cc: kfunk, #frameworks