vandenoever added a comment.
The patch looks clean, but I do not fully understand how is supposed to work. Perhaps an explanation of the different scenarios would help future readers of this code. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D6963 To: davidedmundson, mart Cc: alexeymin, marten, vandenoever, mck182, dvratil, #frameworks