dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land.
Just to be sure, your unittest could also test the case of setEditable(false). REPOSITORY R284 KCompletion BRANCH master REVISION DETAIL https://phabricator.kde.org/D7966 To: mwolff, dfaure Cc: dfaure, #frameworks