elvisangelaccio added inline comments. INLINE COMMENTS
> previewjob.cpp:740-741 > +{ > + QStringList blacklist = QStringList() > + << QStringLiteral("textthumbnail"); > + Shouldn't the blacklist be user-configurable? > previewjob.cpp:745 > + foreach (const QString plugin, blacklist) > + { > + defaultPlugins.removeAll(plugin); code style, brace should be at the end of the previous line > previewjob.h:203-206 > + /** > + * Returns a list of plugins that should be enabled by default, which is > all plugins > + * Minus the plugins specified in an internal blacklist > + */ Documentation should be above the method, not below. > previewjob.h:216 > */ > + > #ifndef KIOWIDGETS_NO_DEPRECATED Unrelated whitespace change REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8347 To: ngraham, #frameworks, broulik, #dolphin Cc: elvisangelaccio, #frameworks