rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land.
As mentioned in the bug, we should wait until after digiKam has had a release containing the change, i.e. 5.8.0. Provoking the dreaded shortcut warning dialog would be a bad way to say "thank you". Roadmap <https://www.digikam.org/documentation/releaseplan/> and NEWS <https://phabricator.kde.org/source/digikam/browse/master/NEWS> say the release was planned for 2017-10-29, but it is still not tagged <https://phabricator.kde.org/source/digikam/tags/master>. We can wait a couple of days, otherwise I assume Frameworks 5.41 (or later, no need to rush) would fit better. That said, more reviewers looking for potential additional conflicts would still be appreciated. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, #frameworks
