mwolff added a comment.
lgtm overall. but I wonder about the naming choice. "Shared" is confusing, to me personally at least. Why not call it "Remote" or "Network"? The reasoning is that "shared" for me is only LAN/WLAN shared stuff, while "remote://" allows arbitrary remote links. I use it to connect via (S)FTP to machines on the internet e.g. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin Cc: mwolff, mlaurent, #frameworks
