subdiff accepted this revision. subdiff added a comment.
Looked at the code and I think @rkflx explained the situation quite well (if we should force passing a parent or not - better - for the QDialogButtonBox). REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx, subdiff Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid, #frameworks
