elvisangelaccio created this revision. elvisangelaccio added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks.
REVISION SUMMARY The "Configure Toolbars" dialog was made non-modal a long time ago [1] in order to allow drag-and-drop of toolbar actions while the dialog is open. This was a bad idea because: 1. It is possible to open the Configure Toolbars dialog and then any other modal dialog (e.g. Configure Shortcuts), making the toolbar dialog unusable. 2. After a drag-n-drop of actions in the toolbar, the order of actions in the "Current actions" column of the toolbar dialog is not updated. Thanks to https://phabricator.kde.org/D8773 we can show the dialog as modal and fix both issues. If some application really wants the dialog as non-modal, it can do so by reimplementing the `KXmlGuiWindow::configureToolbars()` slot. Depends on https://phabricator.kde.org/D8773 [1]: https://phabricator.kde.org/R446:3ea5c463730935c694b26530d911668eff836ddb REPOSITORY R263 KXmlGui BRANCH modal-toolbar-dialog REVISION DETAIL https://phabricator.kde.org/D8774 AFFECTED FILES src/kedittoolbar.cpp src/ktoolbar.h src/kxmlguiwindow.cpp src/kxmlguiwindow.h To: elvisangelaccio, #frameworks, dfaure
