cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land.
Please commit after fixing the last issue. INLINE COMMENTS > FindPulseAudio.cmake:123 > > -mark_as_advanced(PulseAudio_INCLUDE_DIRS PulseAudio_INCLUDE_DIR > - PulseAudio_LIBRARIES PulseAudio_LIBRARY > - PulseAudio_MAINLOOP_LIBRARY) > +mark_as_advanced(PULSEAUDIO_INCLUDE_DIRS PulseAudio_INCLUDE_DIR > + PulseAudio_LIBRARIES PULSEAUDIO_LIBRARY PulseAudio_INCLUDE_DIRS PULSEAUDIO_INCLUDE_DIR REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8777 To: jhirte, #frameworks, cgiboudeaux Cc: rikmills, cgiboudeaux, #build_system