davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcmoduleqml.cpp:143
> +{
> + //FIXME: those are all workarounds around the QQuickWidget brokeness
> + if (watched == d->quickWidget && event->type() == QEvent::KeyPress) {
This needs a link to an upstream bug report.
> kcmoduleqml.cpp:148
> +
> + QQuickItem *currentItem = d->quickWindow->activeFocusItem();
> + if (currentItem->scopedFocusItem()) {
this can be null
> kcmoduleqml.cpp:154
> + if (ke->key() == Qt::Key_Tab) {
> + QQuickItem *nextItem = currentItem->nextItemInFocusChain(true);
> + //when it arrives at the place holder item, go out of the qqw and
can this be null?
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D8522
To: mart, #plasma, #frameworks, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, #frameworks, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
