kfunk added inline comments.

INLINE COMMENTS

> kjobwidgets.cpp:67
> +    if (window) {
> +        job->setProperty("window-id", 
> QVariant::fromValue(qptrdiff(window->winId())));
> +    }

`WId` is a `quintptr`: `src/gui/kernel/qwindowdefs.h:99:typedef 
QT_PREPEND_NAMESPACE(quintptr) WId;`

Besides: `QVariant::fromValue(window->winId())` should work just fine, or?

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D8923

To: apol, #frameworks
Cc: kfunk

Reply via email to