dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > kfileplacesmodel.cpp:913 > > +bool KFilePlacesModel::movePlace(int row, int before) > +{ This should get its own unittest, especially since there are lots of edge cases. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8862 To: renatoo, dfaure, mwolff Cc: mwolff, dfaure, ngraham, #frameworks