smithjd added inline comments. INLINE COMMENTS
> dfaure wrote in kio_tags.cpp:119 > I see an added check for "already exists" and an early return (good), but no > support for KIO::Overwrite. If the user uses dolphin to copy a tag they might > click on "overwrite" and it won't work, if copy() just ignores KIO::Overwrite. KIO::Overwrite is not usable here, because the calls are not relayed to the forwarding slave base. Silently failing is good enough here, IMHO. There's no user action required to recover when a file already has a tag, and no data loss. A popup is unjustifiably intrusive. > dfaure wrote in kio_tags.cpp:292 > This was a rethorical question :-) > It can fail, see `TagListJob::start()`, therefore please check the return > value of exec(). Sorry, I though that I was using start() here, and obviously missed Baloo::TagJob's inherited members.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure Cc: dfaure, nicolasfella, ngraham
