cgiboudeaux created this revision. cgiboudeaux added reviewers: dfaure, apol. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY pkgconfig complains when the .pc file doesn't have a description. eg: $ pkg-config Baloo Package 'Baloo' has no Description: field With this change, if the DESCRIPTION parameter is not used, ECM_GENERATE_PKGCONFIG_FILE will : - First look if there's a metainfo.yaml file and get the description from there - If the file doesn't exist, or if the description tag is empty or non-existent, create a description based on the LIB_NAME value TEST PLAN Tests added & pass REPOSITORY R240 Extra CMake Modules BRANCH pkgconfig-part1 REVISION DETAIL https://phabricator.kde.org/D9056 AFFECTED FILES modules/ECMGeneratePkgConfigFile.cmake tests/ECMGeneratePkgConfigFile/KF5CoreAddons.pc tests/ECMGeneratePkgConfigFile/KF5CoreAddons2.pc tests/ECMGeneratePkgConfigFile/KF5CoreAddons3.pc tests/ECMGeneratePkgConfigFile/metainfo_with_description.yaml tests/ECMGeneratePkgConfigFile/metainfo_with_empty_description.yaml tests/ECMGeneratePkgConfigFile/metainfo_without_description.yaml tests/ECMGeneratePkgConfigFile/run_test.cmake.config To: cgiboudeaux, dfaure, apol Cc: #frameworks, #build_system