dfaure added inline comments. INLINE COMMENTS
> chinmoyr wrote in batchrenamejob.cpp:196 > If the job isn't interactive (like in unit test) then it ends with > ERR_FILE_ALREADY_EXIST error. In case of unit test ignoring the error seems > quite harmless. Ah, yes, makes sense when non-interactive. But this still reads like "risky" code to me. Why not remove the special check? For unittests it means any "existing dest" situation will lead to an error that aborts the whole job, but that's good, no? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9103 To: chinmoyr, #frameworks, dfaure Cc: apol
