mwolff accepted this revision. mwolff added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > kfileplacesmodeltest.cpp:1215 > + QList<QVariant> args = groupHiddenSignal.takeFirst(); > + QCOMPARE(args.at(0).toInt(), (int) KFilePlacesModel::SearchForType); > + QCOMPARE(args.at(1).toBool(), true); `static_cast<int>()` would be preferred, also below REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9241 To: renatoo, franckarrecot, mwolff Cc: mwolff, #frameworks
