cullmann added a comment.
For the QLatin1String on the right side in some contructors: should it not be always QStringLiteral? Not that it will matter a lot. INLINE COMMENTS > dhaumann wrote in kateview.cpp:3595 > Now that's a good point: I don't completely. > It appends a leading and trailing space, and the searches with \b%1 once, and > with %1\b again. But isn't that always true? This is about the highlight > selection feature, and I couldn't spot any difference in behavior. Still > maybe I missed something... I think the old code tried to ensure we only add word-boundary if we still can find the string then. e.g. if the string that you highlight contains spaces or stuff like that at the borders, you don't add \b. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9175 To: dhaumann, cullmann, kfunk, mwolff Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
