rjvbb created this revision. rjvbb added a reviewer: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY This restores proper layering behaviour on Mac, fixing the regression described in the linked bug report (which has screenshots). BUG: 387796 TEST PLAN Changing the window type from Qt::Window to Qt::Dialog was the last tweak I tried and the only one that causes the completion list to display in front of the grandparent window in all known situations on Mac/Cocoa, Mac/X11 and Linux/X11 (even an explicit `raise()` in the evidently locations had no effect). It seems thus safe to apply unconditionally, or else with a simple #ifdef Q_OS_MACOS . REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9289 AFFECTED FILES src/kcompletionbox.cpp To: rjvbb, #framework_syntax_highlighting Cc: kde-mac, #frameworks
