renatoo added a comment.
In https://phabricator.kde.org/D8332#179633, @rkflx wrote: > This change caused a little bit of fallout for #Gwenview. Apparently the review focussed more on the code, but less so on the behaviour in users of the class. I'm not complaining, but given one of our focus goals is on usability and quality of the basic apps, it would be great if: > > - changes were tested more broadly in the future in addition to only looking at the code > - there was some help to fix the fallout > > Please head over to https://bugs.kde.org/show_bug.cgi?id=387824 if you can help Gwenview, thanks! > > --- > > In addition to Gwenview I also looked on lxr and did some testing based on what I found: > - The sidebar in `KDirSelectDialog` is now awful to use, because > - The devices entry (which for some users is more important/useful/frequently used than the search entries) is hidden from view (bad) and requires scrolling (annoying). → We should discuss reordering or (even better) adding collapsing and then collapsing some groups by default. > - The additional scrollbar makes the sidebar so small that you can't read most of the entries. → Add splitter and improve default width. > - To a lesser extent, this also applies to the normal file dialog (no scrollbar by default would be nice). > - Filesystem sidebars in https://phabricator.kde.org/tag/kdevelop/, #Okteta, https://phabricator.kde.org/tag/kile/, https://phabricator.kde.org/tag/kate/ and https://phabricator.kde.org/tag/krusader/: Some of the entries do not make sense in some of those apps at all, e.g. Videos/Images/…. Also some entries show an error message or are broken / show nothing at all (while the same entry works fine in Dolphin). > - That's it at first sight, luckily ;) > > Would be nice to fix those too… Let me know what's the best way forward here, i.e. what are Frameworks issues and where we'd need bugs filed against individual apps. I agree with you comments some entries in the place model does not make sense for some app. What I suggest is create a new function in the model that could filter the entries based on the context of the app. (Docs, Video, Music, Picture) and you can set a flag with any combination of this value. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure, mwolff Cc: rkflx, mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks
