broulik added a comment.
Nice catch.
INLINE COMMENTS
> kjobtrackerformatters.cpp:29
>
> +const char* units[] {"%1 B", "%1 KiB", "%1 MiB", "%1 GiB", "%1 TiB", "%1
> PiB", "%1 EiB", "%1 ZiB", "%1 YiB"};
> +const int unitsSize = sizeof(units)/sizeof(const char *);
These aren't translated anymore. The `translate` call is also a hint that these
strings should be extracted
> kjobtrackerformatters.cpp:31
> {
> - QList<QString> units;
> - units << QCoreApplication::translate("KJobTrackerFormatters", "%1 B")
how about making that list `static` and turning it into an initializer list?
static const auto s_units {
QCoreApplication::translate(...),
...
}
REPOSITORY
R288 KJobWidgets
REVISION DETAIL
https://phabricator.kde.org/D9770
To: jtamate, #frameworks
Cc: broulik
