mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land.
Otherwise all is good. +2 with the QVERIFY(...) INLINE COMMENTS > kdatecomboboxtest.cpp:182 > + combo->activateWindow(); > + QTest::qWaitForWindowActive(combo.data()); > + QVERIFY(QTest::qWa...) REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D8908 To: dfaure, cfeck, dvratil, mlaurent Cc: mlaurent, anthonyfieroni, #frameworks, #kde_pim