dfaure added a comment.
Heh, see the point of writing unittests that actually test the bug ;) It lead to a different fix so it was clearly useful ;) INLINE COMMENTS > urlutil_p.h:69 > const QString parentPath = adjustedCurrentUrl.path(); > + // if the parent path ends in / (after Stripping the trailing Slash) > + // one letter more is a valid path, otherwise two letters are needed. s/S/s/ twice You could also just use adjustedCurrentUrl.path(QUrl::StripTrailingSlash), no? Then you wouldn't have to deal with the fact that the path might end with a slash (and it would also cover the case where it ends with two or more consecutive slashes....) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10071 To: jtamate, #frameworks, dfaure Cc: ngraham