rkflx added a comment.
In https://phabricator.kde.org/D10245#199564, @ngraham wrote: > I could see removing Music and Pictures, maybe. In https://phabricator.kde.org/D10245#199578, @rkflx wrote: > - Remove "Pictures" and "Music" again. In https://phabricator.kde.org/D10245#199643, @ngraham wrote: > Music, maybe. Pictures no You propose a compromise, I agree and suddenly the situation is different again? Let's not rush this, please. > Also, the Pictures item is useful for Gwenview, no? :) It is, but it could be added in Gwenview, just like Kdenlive could add Movies or JuK could add Music. We don't need Pictures in KDevelop, though! When fixing the fallout from https://phabricator.kde.org/D8332 I discovered what you are changing here will propagate to every app using `KUrlNavigator`, which is quite common. (Meanwhile I gave up on adding fixes like https://phabricator.kde.org/R260:50e6fa3ffc490eca33b8e2025120ec041b333fee everywhere, because I realized this has to be solved at Baloo level.) Next big caveat: Our file dialog is used in Okular, Kate and every well-integrated Qt app, where some of the additions make no sense at all. Do you want a Music folder in your EDA and CAD app? I completely agree it is useful in Dolphin. However, then it should be added in Dolphin. TL;DR: - Places and searches useful everywhere should go to KIO. - Specialized stuff (i.e. "Does it only return one specific filetype") should be added in the app or at least be opt-in. Perhaps we need `KExtraFilePlaces` or some mimetype dependent automagic? --- > https://bugs.kde.org/show_bug.cgi?id=389803 That's what I meant. Collapsible headers (i.e. one click, discoverable how to do that only by looking at it) are great. Our current hide-able headers are more of a configuration thing, you wouldn't want to use them regularly. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10245 To: ngraham, #frameworks, #dolphin Cc: markg, spoorun, rkflx, michaelh, ngraham
