ossi added inline comments.
INLINE COMMENTS
> fdsender.cpp:27
> {
> + SocketAddress addr(path.c_str());
> + if (!addr.address()) {
this actually constructs a qbytearray. that should be probably explicit.
a better approach would be moving the class' interface to qbytearray (or
actually qstring) as well, to unify the API. but that's again a separate
refactoring.
> sharefd_p.h:55
> - sockaddr_un a{ AF_UNIX, {0}};
> - std::string finalPath = "/tmp/" + path;
> -#ifdef __linux__
you're removing the auto-prefixing with /tmp/. if that is intentional, you need
to atomically adjust the callers, as otherwise you're changing behavior.
> sharefd_p.h:56
> - std::string finalPath = "/tmp/" + path;
> -#ifdef __linux__
> - ::strcpy(&a.sun_path[1], finalPath.c_str());
i now noticed that you removed that branch, thus removing the use of linux'
abstract address space. that also calls for a justification.
did you research the git history to find out why it was introduced in the first
place?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10273
To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham
