broulik created this revision. broulik added reviewers: Plasma, VDG, Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY This avoids a double "Places" header and also gets rid of the superfluous frame around the widget, similar to Dolphin. It has never been possible to detach the dock from the window anyway. The close button is also removed as a side-effect of this but should a user really want to hide it, this can still be done by pressing F9 or in the menu. Resizing the places list is still possible. TEST PLAN Before F5693291: Screenshot_20180205_161053.png <https://phabricator.kde.org/F5693291> After F5693292: Screenshot_20180205_161002.png <https://phabricator.kde.org/F5693292> I just noticed in Oxygen it always paints a frame around it and you end up with a lot of padding at the top. When I completely remove the header item, it looks strange with the places crammed at the top: F5693295: Screenshot_20180205_161901.png <https://phabricator.kde.org/F5693295> REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10325 AFFECTED FILES src/filewidgets/kfilewidget.cpp To: broulik, #plasma, #vdg, #frameworks Cc: plasma-devel, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
