alexeymin added a comment.

  `quit()` and `exit(0)` do the same thing - they all stop event loop, caused 
by `QCoreApplication::exec()`.
  
  And I don't understand how does timer help? What is happening without 
singleshot timer?

INLINE COMMENTS

> monitorcommand.cpp:55
> +            m_out << i18n("Baloo died") << endl;
> +            QCoreApplication::instance()->exit(0);
> +        });

`QCoreApplication::exit()` is a static member function and can be called 
directly without using `instance()`.
`instance()->quit()` is exactly the same as `exit(0)` so I don't understand 
this change. It does not change anything and looks not correct.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10335

To: michaelh, #baloo, #frameworks
Cc: alexeymin, michaelh, ngraham

Reply via email to