mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > kpluginfactory.h:211 > + */ > +#define K_PLUGIN_CLASS_WITH_JSON(classname, jsonFile) > K_PLUGIN_FACTORY_WITH_JSON(classname ## Factory, json, > registerPlugin<classname >();) > + it's doesn't work. jsonFile in all macro or json only otherwise it's not defined. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10333 To: aacid, dfaure, mlaurent Cc: mlaurent, kossebau, apol, #frameworks, michaelh, ngraham
