mwolff added a comment.
In D7968#206500 <https://phabricator.kde.org/D7968#206500>, @whiting wrote: > Hey all, this change breaks Kompare https://bugs.kde.org/show_bug.cgi?id=390024 which watches a KUrlRequester's textChanged signal to update a button's enabled state. We are not seeing the textChanged signal on the KUrlRequester anymore when programatically setting the url with the KUrlComboBox we give to the KUrlRequester via it's setUrl method. Looking at KUrlComboBox::setUrl it's blocking signals in the body of setUrl and since we are not connecting to the QLineEdit anymore we never get that signal. So to be clear the bug is: - connected to KUrlRequester::textChanged - calling KUrlRequester->comboBox()->setUrl() - no textChanged signal emitted this isn't covered by the test, so we need to add that and ensure it works REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7968 To: mwolff, apol, dfaure Cc: whiting, #frameworks, michaelh
