apol added inline comments. INLINE COMMENTS
> karchive.cpp:829 > { > - if (d->entries.value(entry->name())) { > - /*qCWarning(KArchiveLog) << "directory " << name() > - << "has entry" << entry->name() << "already";*/ > - delete entry; > + if (d->entries.value(entry->name()) == entry) { > + qCWarning(KArchiveLog) << "directory " << name() Cache the value not to query twice? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D10543 To: sandsmark, dfaure, #frameworks Cc: apol, michaelh