ngraham added a comment.
These kinds of changes to Solid are going to need some *ahem* solid testing (I just kill myself sometimes) to avoid regressions, like the one we had in https://bugs.kde.org/show_bug.cgi?id=389479 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10657 To: broulik, #frameworks, davidedmundson, apol Cc: ngraham, michaelh