apol added inline comments. INLINE COMMENTS
> metadata.desktop:88 > X-KDE-PluginInfo-Email=%{EMAIL} > -X-KDE-PluginInfo-Name=%{APPNAMELC} > +X-KDE-PluginInfo-Name=org.kde.plasma.%{APPNAMELC} > X-KDE-PluginInfo-Version=1.0 I'm not sure, if a 3rd party makes a plasmoid they would call it otherwise. Are we assuming these templates are only for KDE? > %{APPNAMELC}plugin.cpp:33 > QJSValue helloWorld = scriptEngine->newObject(); > - helloWorld.setProperty("text", QStringLiteral("Hello world!")); > + helloWorld.setProperty("text", i18n("Hello world!")); > return helloWorld; Isn't his a rather clunky dependency there? I like templates as easy and plain as possible... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10848 To: kossebau, mart Cc: apol, #frameworks, michaelh