aleksejshilin added inline comments.
INLINE COMMENTS
> dfaure wrote in kurlnavigator.cpp:349
> Is this in order to get smb:// instead of smb: ? It looks correct, but not
> for "file", how about moving that to an else{} branch of the if below? And I
> could add a comment like "we want smb:// or ftp://, not just smb: or ftp:".
> Is this in order to get smb:// instead of smb: ?
Yes.
> It looks correct, but not for "file",
Why not? If I read RFC 8089 correctly, for host rule it references RFC 3986
which allows it to be empty, i.e. an empty authority is valid.
> And I could add a comment like "we want smb:// or ftp://, not just smb: or
> ftp:".
Makes sense, indeed. Will do shortly.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10993
To: aleksejshilin, #frameworks, dfaure
Cc: michaelh
