dfaure added inline comments. INLINE COMMENTS
> sharefd_p.h:85 > + msg.msg_iovlen = 1; > + msg.msg_control = &cmsg_buf; > + msg.msg_controllen = sizeof cmsg_buf; Looks good, it's just a bit inconsistent that iov_base points to io_buf (without &) and msg_control points to &cmsg_buf (with &), both members being char [N]. It turns out that both work, but why not use the same syntax both times? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D11011 To: chinmoyr, dfaure, awilcox Cc: #frameworks, michaelh
