dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > slavebase.cpp:150 > +#ifdef Q_OS_UNIX > + QSet<QString>::const_iterator it = m_tempAuths.begin(); > + while (it != m_tempAuths.end()) { This can't be a const_iterator, if you use it for erase()ing. I'm surprised this compiles... > slavebase.cpp:161 > + > + bool hasTempAuth() > + { const REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10820 To: chinmoyr, dfaure Cc: anthonyfieroni, #frameworks, michaelh