dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land.
(Reusing the same phab request is fine in this case, because there were no review comments yet. Once there are, and they don't apply to a completely redesigned commit, then indeed better start a new phab request.) This commit looks ok, but I would merge it with the one that adds the method addTemporaryAuthorization(actionId), they go together. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10437 To: chinmoyr, #frameworks, dfaure, fvogt Cc: markg, anthonyfieroni, michaelh