chinmoyr added inline comments.

INLINE COMMENTS

> dfaure wrote in klauncher.cpp:1114
> This deletes the Slave C++ class, but it doesn't actually kill the ioslave.
> So why do it?
> 
> I'm confused now. Do you want to kill the ioslave (then call slave->kill())
> or do you want to reuse that ioslave, just without any of the previous 
> authorizations (which is what I thought you were doing in slaveStatus()) ?
> If the latter, then why the delete here?

I meant to kill the slave and not reuse it. 
And IdleSlave subclasses QObject and doesn't have kill() which is why I used 
deleteLater which actually kills the IdleSlave.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D10824

To: chinmoyr, dfaure, #frameworks
Cc: #frameworks, michaelh

Reply via email to