mwolff accepted this revision. mwolff added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > kiconeffect.cpp:44 > + KIconEffectPrivate() > + : effect{{}} > + , value{{}} it may be a good idea to add a comment that links to http://en.cppreference.com/w/cpp/language/zero_initialization to clarify what's happening here REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D11132 To: jtamate, #frameworks, mwolff Cc: mwolff, apol, anthonyfieroni, michaelh