astippich requested changes to this revision.
astippich added a comment.
This revision now requires changes to proceed.
Looks good imho, just one small comment inline. of course, @mgallien as the
maintainer must also give his ok.
INLINE COMMENTS
> taglibextractor.cpp:331
> + } else {
> + extractOgg(stream, mimeType, data);
> }
I think we should check explicitly for the appropriate mimetypes here
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D10918
To: michaelh, mgallien, #baloo, #frameworks, astippich
Cc: astippich, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham,
alexeymin
